fix: Add stage initialization check in _onResize#4301
Merged
walterbender merged 1 commit intosugarlabs:masterfrom Jan 24, 2025
Merged
fix: Add stage initialization check in _onResize#4301walterbender merged 1 commit intosugarlabs:masterfrom
walterbender merged 1 commit intosugarlabs:masterfrom
Conversation
Contributor
Author
|
@walterbender Could you please take a look, and let me know if any changes are needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
fixes #4300
This PR adds a defensive check in the
_onResizemethod to ensurethis.stageis properly initialized before executing resize operations. This prevents potential errors during the application's initialization phase.Changes Made
_onResizemethodBefore
The
_onResizemethod would attempt to accessthis.stageproperties before initialization was complete.After
Method is only called when the stage is available
Testing Done